Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shell.nix to nixpkgs-24.05 and LLVM 18 #14651

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use libiconvReal on macOS
  • Loading branch information
straight-shoota committed Nov 4, 2024
commit dd8d8fee1775463fd2bd90d706f4af9a7e5045c7
4 changes: 2 additions & 2 deletions .github/workflows/macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
run: bin/ci prepare_build

- name: Test
run: bin/ci build
run: CRYSTAL_OPTS=-Duse_libiconv bin/ci build

- name: Test interpreter
run: bin/ci with_build_env 'make interpreter_spec'
run: bin/ci with_build_env 'CRYSTAL_OPTS=-Duse_libiconv make interpreter_spec'
2 changes: 1 addition & 1 deletion shell.nix
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ let

stdLibDeps = with pkgs; [
boehmgc gmp libevent libiconv libxml2 libyaml openssl pcre2 zlib
] ++ lib.optionals stdenv.isDarwin [ libiconv ];
] ++ lib.optionals stdenv.isDarwin [ libiconvReal ];

tools = [ pkgs.hostname pkgs.git llvmPackages.bintools ] ++ pkgs.lib.optional (!llvmPackages.lldb.meta.broken) llvmPackages.lldb;
in
Expand Down
Loading