Fix interpreter internal overflow for UInt128#to_f32 and #to_f32!
#14437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
added
kind:bug
HertzDevil
changed the title
UInt128#to_f32 in the interpreterUInt128#to_f32 and #to_f32! in the interpreter
HertzDevil
changed the title
UInt128#to_f32 and #to_f32! in the interpreterUInt128#to_f32 and #to_f32!
straight-shoota
approved these changes
Apr 6, 2024
ysbaddaden
approved these changes
Apr 7, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes code like
UInt128::MAX.to_f32raiseOverflowErrorin the interpreted code, not in the interpreter itself. Also makesUInt128::MAX.to_f32!not raise anyOverflowError.This was discovered by running
spec/primitives/int_spec.crwith the interpreter.