Skip to content

Automatically detect MSVC tools on Windows interpreter #14391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2024
Merged

Automatically detect MSVC tools on Windows interpreter #14391

merged 1 commit into from
Mar 25, 2024

Conversation

HertzDevil
Copy link
Contributor

Recreates the MSVC developer prompt environment so that the interpreter can be used outside such a prompt, similar to normal compilation.

@HertzDevil HertzDevil added kind:feature platform:windows Windows support based on the MSVC toolchain / Win32 API topic:compiler:interpreter labels Mar 22, 2024
beta-ziliani
beta-ziliani approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@beta-ziliani beta-ziliani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Quinton! 🙇

EDIT: we need to wait for CI, but I sense there won't be issues here, as it's mostly a moving of code for the compiler, and a new thing for the interpreter.

@beta-ziliani beta-ziliani added this to the 1.12.0 milestone Mar 22, 2024
@straight-shoota straight-shoota merged commit f0afa88 into crystal-lang:master Mar 25, 2024
@HertzDevil HertzDevil deleted the feature/windows-interpreter-detect-msvc branch March 25, 2024 12:53
@BrewTestBot BrewTestBot mentioned this pull request Apr 9, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beta-ziliani beta-ziliani beta-ziliani approved these changes

Assignees

No one assigned

Labels

kind:feature platform:windows Windows support based on the MSVC toolchain / Win32 API topic:compiler:interpreter

Projects

Windows Support
Status: Done

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

3 participants

@HertzDevil @beta-ziliani @straight-shoota