Fix: Crystal::RWLock should be a struct
#14345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Crystal::RWLock type is used to protect the GC against fiber context switches, to avoid the GC interrupting a thread while it is switching contexts, or starting a collection while a thread was preempted by the kernel while it was switching the fiber context. Problem is: Crystal::RWLock is a class, and thus depends on the GC to be allocated, and we end up in an infinite loop: GC depends on Crystal::RWLock that itself depends on GC, ... The weirdest part is that it's working, and I have no idea how.
straight-shoota
approved these changes
Mar 5, 2024
straight-shoota
added
kind:bug
straight-shoota
changed the title
Crystal::RWLock should be a struct
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Crystal::RWLock type is used to protect the GC against fiber context switches, to avoid the GC interrupting a thread while it is switching to another fiber, or starting a collection while a thread was preempted by the kernel while it was switching to another fiber.
Problem is: Crystal::RWLock is a class, and as such depends on the GC to be allocated, and... we end up in an infinite loop: GC <-> Crystal::RWLock.
The weirdest part is that it's working, and I have no idea how.