Respect --static on Windows
#14292
Merged
Respect --static on Windows
#14292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
added
kind:feature
topic:infrastructure
platform:windows
straight-shoota
approved these changes
Feb 13, 2024
straight-shoota
approved these changes
Feb 19, 2024
1 task
straight-shoota
pushed a commit
to crystal-lang/crystal-book
that referenced
this pull request
Nov 8, 2024
Dynamic linking has been the default for MSVC since Crystal 1.12.0 (crystal-lang/crystal#14292).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
--staticopt in to static linking on Windows. Also makes the Windows binaries dynamically linked.Dynamic linking is now the default, and the
-Dpreview_dllflag has no effect after this PR. Building a dynamically linked compiler from 1.11.x still needs this flag though, because the base compiler doesn't incorporate this PR yet.Note that linking against
vcruntimemeans that the VC++ Redistributable is now required to run the compiler. The GUI installer must later be able to detect its installation (e.g. via the registry keyHKLM\SOFTWARE\Microsoft\VisualStudio\14.0\VC\Runtimes\X64\Installed).