Fix: don't run thread specs with the interpreter #14287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting threads very likely requires support from the interpreter to create the thread (so it knows about it) to run the interpreted code in. This also fixes the "can't resume running fiber" exceptions that started appearing in the wait group pull request, because they were always run after the thread related specs.
FTR: Specs indeed run in random order in CI (this is configured in |
straight-shoota
approved these changes
Feb 6, 2024
|
@straight-shoota running It's probably because the workflow splits the specs to run N%4 specs, which means we'd need to create a random seed for each run, and share it between each parallel job... |
|
Ah, yeah. You're right. I had even tried to verify that the failing spec from #14167 is actually using |
HertzDevil
approved these changes
Feb 8, 2024
ysbaddaden
deleted the
fix/dont-run-thread-specs-with-the-interpreter
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting threads very likely requires support from the interpreter to create the thread (so it knows about it) to run the interpreted code in.
This fixes the "can't resume running fiber" exceptions that started appearing in the WaitGroup pull request, because they were always run after the thread related specs.
What's happening is that either the interpreter or the interpreted code becomes confused, and the scheduler is trying to resume a fiber that's already running in another thread (it might even be a thread's main fiber).
Running the specs in random order (instead of sequentially) would likely trigger the issue.