Skip to content

Conversation

HertzDevil
Copy link
Contributor

Prioritizes DLLs at CRYSTAL_LIBRARY_PATH, the compiler's directory, and PATH, just like #14131 in compiled code. Note that the DLL in the same directory as the import library is no longer considered, since CRYSTAL_LIBRARY_PATH should already be sufficient.

The default DLL search order is still needed for things like system DLLs.

@HertzDevil HertzDevil added kind:feature platform:windows Windows support based on the MSVC toolchain / Win32 API topic:compiler:interpreter labels Dec 28, 2023
@straight-shoota straight-shoota added this to the 1.12.0 milestone Jan 11, 2024
@straight-shoota straight-shoota merged commit bb96c53 into crystal-lang:master Jan 13, 2024
@HertzDevil HertzDevil deleted the feature/windows-interpreter-dll-search branch January 31, 2024 12:31
straight-shoota pushed a commit that referenced this pull request Sep 10, 2024
This has been addressed by #14146 from outside the loader, and there is essentially only one TODO left for #11575.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:feature platform:windows Windows support based on the MSVC toolchain / Win32 API topic:compiler:interpreter

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants