Docs: Add note about graphemes in String#reverse
#13536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
reviewed
May 31, 2023
puts is implicit Co-authored-by: Quinton Miller <nicetas.c@gmail.com>
HertzDevil
approved these changes
May 31, 2023
straight-shoota
approved these changes
Jun 5, 2023
straight-shoota
changed the title
String#reverse
straight-shoota
changed the title
String#reverseString#reverse
Blacksmoke16
pushed a commit
to Blacksmoke16/crystal
that referenced
this pull request
Dec 11, 2023
Co-authored-by: Quinton Miller <nicetas.c@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: documentation 📖
State that
String#reverseworks on Unicode graphemes (and not codepoints) so combining characters are preserved.