Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix client-side TCPSocket#remote_address on Windows #13363

Merged
merged 3 commits into from
Apr 21, 2023
Merged

Fix client-side TCPSocket#remote_address on Windows #13363

merged 3 commits into from
Apr 21, 2023

Conversation

HertzDevil
Copy link
Contributor

This is done by setting the SO_UPDATE_CONNECT_CONTEXT option upon successful connection, just as SO_UPDATE_ACCEPT_CONTEXT is required upon successful listening.

@HertzDevil HertzDevil added kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:networking labels Apr 20, 2023
@straight-shoota straight-shoota added this to the 1.9.0 milestone Apr 20, 2023
@straight-shoota straight-shoota merged commit 7732579 into crystal-lang:master Apr 21, 2023
@HertzDevil HertzDevil deleted the bug/windows-socket-client-remote-address branch April 21, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:networking
Projects
Windows Support
Status: Done
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@HertzDevil @straight-shoota