Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update previous Crystal release - 1.7.3 #13167

Merged

Conversation

straight-shoota
Copy link
Member

No description provided.

@beta-ziliani
Copy link
Member

Smoke tests are all failing because they lack libpcre2

@straight-shoota
Copy link
Member Author

But this doesn't change anything in smoke.yml...? 😕

@straight-shoota
Copy link
Member Author

straight-shoota commented Mar 14, 2023

Ah, so the 1.7.3-build image does not include libpcre2. But 1.7.2-build does because we updated them after the release.

I don't know why that only breaks smoke tests, though. This should affect all specs that build the compiler in the 1.7.3 image. 🤷
Guess we need to re-publish the 1.7.3-build images with crystal-lang/distribution-scripts#219 as well. I thought we had updated the 1.7 branch with that, but apparently not.

@straight-shoota
Copy link
Member Author

FTR: It's not just smoke tests, but actually all linux jobs that make use of the build docker image.

It should be fixed now. The -build docker images have been updated to include libpcre2.

@straight-shoota straight-shoota added this to the 1.8.0 milestone Mar 21, 2023
@straight-shoota straight-shoota merged commit 31c17f7 into crystal-lang:master Mar 22, 2023
@straight-shoota straight-shoota deleted the feature/release-update branch March 22, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants