-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Char.to_i128
and .to_u128
#12900
Add Char.to_i128
and .to_u128
#12900
Conversation
What's the point of doing this with a non-flags enum? Maybe the old method should have raised a compile error in that case. And now I'm thinking flags is a better name than brackets. |
Yeah, that's a legitimate question. |
I'm worried about the amount of deprecation messages that we will throw in the face of the entire Crystal ecosystem's devs. I wonder if we shouldn't allow ourselves to have two ways of doing it for a while, mention in the docs that |
What's wrong with keeping the name flags? |
Sure, let's keep @asterite It's effectively an alias for |
Enum.[]
convenience constructorChar.to_i128
and .to_u128
Resolves #12892
Related to #12884
Also deprecates
Enum.flags
which is replaced byEnum.[]
.