Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XML::Node#errors to return nil when empty #12795

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Fix XML::Node#errors to return nil when empty #12795

merged 2 commits into from
Nov 30, 2022

Conversation

straight-shoota
Copy link
Member

This restores the original semantics prior to the refactoring of #12663

Ref: #12663 (comment)

@straight-shoota
Fix XML::Node#errors to return nil when empty
1f2dd2e 
This restores the original semantics prior to the refactoring of crystal-lang#12663
@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:serialization kind:regression Something that used to correctly work but no longer works labels Nov 28, 2022
@beta-ziliani beta-ziliani added this to the 1.7.0 milestone Nov 28, 2022
@straight-shoota straight-shoota merged commit a83537e into crystal-lang:master Nov 30, 2022
@straight-shoota straight-shoota deleted the fix/xml-error-empty-is-nil branch November 30, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beta-ziliani beta-ziliani beta-ziliani approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:regression Something that used to correctly work but no longer works topic:stdlib:serialization
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@straight-shoota @beta-ziliani