Fix: Do not merge union types in truthy filter #12752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
kind:bug
asterite
approved these changes
Nov 17, 2022
asterite
reviewed
Nov 17, 2022
asterite
reviewed
Nov 17, 2022
Co-authored-by: Ary Borenszweig <asterite@gmail.com>
|
x = 1 || ""
if x.as?(String)
x.codepoints # Error: undefined method 'codepoints' for Int32 (compile-time type is (Int32 | String))
endAssignment to a separate variable is necessary here. |
|
Yes, that's what the spec is supposed to do. Seems to have ended up differently when I refactored it before publishing the PR, and the edit suggestions didn't help either 🙈 Correct example is in #12751 Fixed it now. |
beta-ziliani
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12751