Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assignment to global regex match data is not allowed #12714

Merged
merged 4 commits into from
Nov 11, 2022
Merged

Assignment to global regex match data is not allowed #12714

merged 4 commits into from
Nov 11, 2022

Conversation

caspiano
Copy link
Contributor

@caspiano caspiano commented Nov 2, 2022

Closes #12711

@caspiano caspiano added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:parser labels Nov 2, 2022
@HertzDevil
Copy link
Contributor

HertzDevil commented Nov 2, 2022 •
edited
Loading

Might want to check multiassign_left_hand too, to disallow multiple assignment ($0, $1 = [2, 3])

sdogruyol
sdogruyol approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @caspiano 🙏

@straight-shoota straight-shoota added this to the 1.7.0 milestone Nov 9, 2022
@straight-shoota straight-shoota merged commit 3334369 into crystal-lang:master Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija left review comments

@straight-shoota straight-shoota straight-shoota approved these changes

@sdogruyol sdogruyol sdogruyol approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:parser
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Unexpected behavor for compiler transform $0 = "hello" into a syntax error form
5 participants
@caspiano @HertzDevil @Sija @straight-shoota @sdogruyol