Use single helper method to pass UTF-16 strings to Windows #12695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
added
kind:refactor
platform:windows
HertzDevil
force-pushed
the
refactor/windows-to_wstr
branch
from
e5df8dc
to
a2ee1b4
Compare
straight-shoota
approved these changes
Oct 30, 2022
caspiano
approved these changes
Oct 30, 2022
straight-shoota
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all the
check_no_null_byte.to_utf16.to_unsafecalls in the Win32 interfaces into a single method, and also renames it fromto_windows_pathto justto_wstrto indicate that it can be used with non-path values.