Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spec/generate_windows_spec.sh #12549

Conversation

straight-shoota
Copy link
Member

This is a follow-up to #12282

With the removal of spec/win32_std_spec.cr we don't need its generator script anymore.

#12282 mentions a cause for not deleting this:

The script that generates spec/win32_std_spec.cr remains intact in case we want to reuse it for some other completely new system.

But I think we should still delete it to clean up this unused artifact. We can always dig it up from the history if we want to reuse it somehow (note there's also the similar spec/generate_interpreter_spec.sh by now).

@straight-shoota straight-shoota added topic:infrastructure platform:windows Windows support based on the MSVC toolchain / Win32 API kind:specs labels Sep 30, 2022
@straight-shoota straight-shoota added this to the 1.6.0 milestone Sep 30, 2022
@straight-shoota straight-shoota merged commit 395fda7 into crystal-lang:master Oct 2, 2022
@straight-shoota straight-shoota deleted the spec/remove-generate_windows_specs branch October 2, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:specs platform:windows Windows support based on the MSVC toolchain / Win32 API topic:infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants