Always use GC_set_stackbottom
on Windows
#12186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Boehm GC pushes all stacks during a collection cycle, with POSIX Threads it uses
GC_stackbottom
as the bottom of the main thread's stack, but on Windows, it always uses an internal per-thread handle'sstack_base
member. This member is updated byGC_set_stackbottom
. This means it is insufficient to assign directly toLibGC.$stackbottom
, because then the GC would incorrectly collect memory reachable only from the main fiber if a different fiber is running while a collection cycle starts.This fix gets rid of the occasional
Thread stack pointer ... out of range, pushing everything
warnings, and should also make theselect
stress test pass.