Support generic types in Crystal::Macros::Type#is_a?
#12118
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11981. With this, all the type names used in the macro method docs will actually mean something (even if they aren't used yet).
This PR makes the following macro types generic:
But see #11981 (comment) on whether the last two should become variadic.
The second commit forbids all of the short forms that are previously allowed in arguments to the macro
#is_a?
. As mentioned in #11981, they never worked in the first place, because no AST node's#class_name
ever contains those short forms or the type names they expand to:A corresponding PR for the reference manual will follow shortly.