-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Indexable#index!
overloads with offset
parameter
#12089
Add Indexable#index!
overloads with offset
parameter
#12089
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a discrepancy between the parameter name in code (object
) and in the docs (value
). #index
uses object
, so that seems to be the natural choice.
The base overload actually uses |
I'd prefer Thumbs up please, if you agree =) |
No other methods in On the other hand, |
I don't think it would be wise to do any renamings on the whole standard library in here, so to move forward I suggest using |
Follow-up to #11566.
Indexable#index
overridesEnumerable#index
and has an extra parameter, so it makes sense the raising variant should be overridden in a similar way. (There are further overrides inIndexable
's including types, but they do not introduce any new signatures, so this PR will suffice.)