Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dir#info #11991

Merged
merged 8 commits into from
Jul 14, 2022
Merged

Add Dir#info #11991

merged 8 commits into from
Jul 14, 2022

Conversation

didactic-drunk
Copy link
Contributor

No description provided.

@didactic-drunk
Copy link
Contributor Author

Idk why windows fails.

@straight-shoota
Copy link
Member

I can reproduce the windows error locally. But couldn't identify a reason either without digging any deeper.

If you don't want to investigate further, it's fine to stub out the windows implementation for now (similar to wasi) and mark the spec as pending.

Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @didactic-drunk 🙏

@straight-shoota straight-shoota added this to the 1.6.0 milestone Jun 26, 2022
@straight-shoota straight-shoota changed the title Add Dir#info Add Dir#info Jul 14, 2022
@straight-shoota straight-shoota merged commit b1ff001 into crystal-lang:master Jul 14, 2022
@didactic-drunk didactic-drunk deleted the dir_info branch July 14, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants