Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatter for parenthesized arg after space #11972

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Fix formatter for parenthesized arg after space #11972

merged 1 commit into from
Jun 9, 2022

Conversation

straight-shoota
Copy link
Member

Resolves #11722

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:tools:formatter kind:regression Something that used to correctly work but no longer works labels Apr 5, 2022
beta-ziliani
beta-ziliani approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ftarulla says it's good, I say it's good

@beta-ziliani beta-ziliani added this to the 1.5.0 milestone Jun 8, 2022
@straight-shoota straight-shoota merged commit 7fabd1b into crystal-lang:master Jun 9, 2022
@straight-shoota straight-shoota deleted the fix/formatter-nested-parentheses branch June 9, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beta-ziliani beta-ziliani beta-ziliani approved these changes

@ftarulla ftarulla ftarulla approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:regression Something that used to correctly work but no longer works topic:tools:formatter
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Regression in formatter with nested parentheses
3 participants
@straight-shoota @ftarulla @beta-ziliani