Skip to content

Use Int128 and UInt128 literals for compiler_rt specs #11944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Use Int128 and UInt128 literals for compiler_rt specs #11944

wants to merge 2 commits into from

Conversation

lbguilherme
Copy link
Contributor

This fixes a TODO to remove make_ti and make_tu once 128-bit literals are supported.

@HertzDevil
Copy link
Contributor

I don't think anything in the standard library can use 128-bit literals as long as we have CI using 1.0.0 as the base compiler.

@straight-shoota
Copy link
Member

straight-shoota commented Mar 28, 2022 •
edited
Loading

This is similar to #5545 which we can't merge unless ensuring compatibility with Crystal 1.0 (see #5545 (comment)).
Since this is only about compiler_rt specs, I suppose we could just skip these specs for older Crystal versions and still merge it.

@lbguilherme
Copy link
Contributor Author

As these are only spec changes, I thought this wasn't an issue. But this PR can sit waiting for a while I guess, I see multiple CI failures.

BlobCodes
BlobCodes reviewed Mar 30, 2022
View reviewed changes
spec/std/crystal/compiler_rt/divmod128_spec.cr
test__divti3(make_ti(-9223372036854775808, 0x0), -1, make_ti(-9223372036854775808, 0x0))
test__divti3(make_ti(-9223372036854775808, 0x0), -2, make_ti(0x4000000000000000, 0x0))
test__divti3(make_ti(-9223372036854775808, 0x0), 2, make_ti(-0x4000000000000000, 0x0))
test__divti3(0x80000000000000000000000000000000_u128.to_i128!, 1, 0x80000000000000000000000000000000_u128.to_i128!)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 0x80000000000000000000000000000000_u128.to_i128! and not -0x80000000000000000000000000000000_i128

@straight-shoota straight-shoota added this to the 2.0.0 milestone May 30, 2022
@straight-shoota straight-shoota marked this pull request as draft May 30, 2022 21:15
@straight-shoota
Copy link
Member

Marking as draft because we probably won't merge this in the near future (see #5545 (comment)).

@beta-ziliani beta-ziliani mentioned this pull request Jan 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlobCodes BlobCodes BlobCodes left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
kind:refactor topic:stdlib:numeric
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lbguilherme @HertzDevil @straight-shoota @BlobCodes