Fix: Do not consider global Path in def parameter restriction as free variable
#11862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
added
kind:bug
straight-shoota
approved these changes
Mar 1, 2022
straight-shoota
changed the title
Paths in def parameter restrictions as free variablesPath in def parameter restriction as free variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given:
::Tis a global path, so it should always refer to the typeTfrom the top-level namespace, never the free variable. The above snippet now reportsundefined constant ::T. If::Twere defined, thenfoo's argument must also be of typeT.Defs like these are now subject to #7737.
Also includes slight refactors outside
restrictions.cr.