Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --m* flags to crystal spec and crystal eval #11767

Conversation

yxhuvud
Copy link
Contributor

@yxhuvud yxhuvud commented Jan 25, 2022

These are flags that a user may want to set globally in CRYSTAL_OPTS.
Hence neither crystal spec or crystal eval should fail if they are set.

Fixes #11670

These are flags that a user may want to set globally in CRYSTAL_OPTS.
Hence neither crystal spec or crystal eval should fail if they are set.
@yxhuvud
Copy link
Contributor Author

yxhuvud commented Jan 25, 2022

Specs for the command line options would be nice, but I'm not certain how to add them in a reasonable way. If this had been crystal and rspec I'd probably stubbed Compiler.new and the relevant methods on compiler, but that doesn't seem practical here.

@straight-shoota straight-shoota added this to the 1.4.0 milestone Jan 28, 2022
@straight-shoota straight-shoota changed the title Support -m-flags for crystal spec and crystal eval. Add support for -m* flags to crystal spec and crystal eval Jan 29, 2022
@straight-shoota straight-shoota changed the title Add support for -m* flags to crystal spec and crystal eval Add support for --m* flags to crystal spec and crystal eval Jan 29, 2022
@straight-shoota straight-shoota merged commit aa8bbd7 into crystal-lang:master Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--mcpu doesn't work on crystal spec
3 participants