Refactor Colorize::Mode enum
#11663
Merged
Refactor Colorize::Mode enum
#11663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: r00ster91 <r00ster91@protonmail.com>
Sija
reviewed
Dec 28, 2021
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
j8r
reviewed
Dec 28, 2021
caspiano
reviewed
Dec 29, 2021
Co-authored-by: Caspian Baska <email@caspian.computer>
oprypin
reviewed
Dec 30, 2021
oprypin
approved these changes
Dec 30, 2021
vlazar
reviewed
Jan 21, 2022
| end | ||
|
|
||
| private def each_code(mode : Colorize::Mode) | ||
| yield '1' if mode.bold? |
There was a problem hiding this comment.
I know the result would be the same, but for readability I wish it was explicitly covering all enum members.
yield '1' if mode.bold? || mode.bright?Maybe compiler could be (is) smart enough to make it noop, but humans would see all cases covered.
Or maybe just comment.
There was a problem hiding this comment.
I don't think the compiler can easily optimize this.
I'll add a comment to the member definition. That's probably more useful than here in this internal implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #7690
This is mostly an internal refactoring. Only effect on the API is that invalid symbols are now a compile time error instead of runtime error. That could be considered a breaking change, but it's an improvement for error detection.