Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Regex#name_table to return Hash(Int32, String) #11539

Merged

Conversation

straight-shoota
Copy link
Member

Resolves #11528

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. breaking-change topic:stdlib:text labels Dec 4, 2021
@straight-shoota straight-shoota changed the title Change Regex#name_type to return Hash(Int32, String Change Regex#name_type to return Hash(Int32, String) Dec 4, 2021
@straight-shoota straight-shoota added this to the 1.3.0 milestone Dec 5, 2021
@straight-shoota straight-shoota merged commit 4978e4b into crystal-lang:master Dec 13, 2021
@straight-shoota straight-shoota deleted the feature/regex-name_table branch December 13, 2021 18:39
@Sija
Copy link
Contributor

Sija commented Dec 13, 2021

@straight-shoota There's a typo in the PR title, should be Regex#name_table (not name_type).

@straight-shoota straight-shoota changed the title Change Regex#name_type to return Hash(Int32, String) Change Regex#name_table to return Hash(Int32, String) Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:text
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regex#name_table returns Hash(UInt16, String)
4 participants