Allow compiler executable under test to be overridden #11457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good! I think the env var name should be |
|
|
|
|
|
Perhaps a bit shorter |
straight-shoota
approved these changes
Nov 17, 2021
oprypin
approved these changes
Nov 20, 2021
| @@ -13,7 +13,7 @@ input = ARGV[0] | |||
| bin = File.join(tmp_build_dir, "debug_test_case") | |||
| debugger_script = File.join(tmp_build_dir, "./debugger.script") | |||
|
|
|||
| `#{repo_base_dir}/bin/crystal build --debug #{input} -o #{bin}` | |||
| Process.run(ENV["CRYSTAL_SPEC_COMPILER_BIN"]? || "#{repo_base_dir}/bin/crystal", ["build", "--debug", input, "-o", bin]) | |||
There was a problem hiding this comment.
This was already problematic before, so feel free to ignore, but we now have a good opportunity to check that this command actually succeeded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an environment variable
SPEC_COMPILERwhich, when set, overrides the Crystal compiler executable being used in specs.This is mainly relevant for local development on Windows. Unlike on CI,
bin\crystal.exerelative to the repository root is normally not expected to exist, because the local compiler is supposed to go into.buildinstead; also unlike on Unix,bin\crystalmust resolve to an.exe, never some other script likebin\crystal.bat. With this PR, any installation of Crystal or wrapper script can be used in place ofbin/crystal.crystal specautomatically sets this environment variable to the compiler process itself if the variable is absent, before building the specs (not just before running, so thatSPEC_COMPILERwould always be available even in macros). If the specs are built and then run separately, like on CI, thenSPEC_COMPILERshould also be set beforehand (our workflows don't need this).