Allow assignments from generic instance metaclasses to virtual metaclasses #11250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
added
kind:bug
straight-shoota
approved these changes
Sep 27, 2021
| end | ||
|
|
||
| def assign_distinct(target_pointer, target_type : VirtualMetaclassType, value_type : VirtualMetaclassType, value) | ||
| def assign_distinct(target_pointer, target_type : VirtualMetaclassType, value_type : MetaclassType | GenericClassInstanceMetaclassType | GenericModuleInstanceMetaclassType | VirtualMetaclassType, value) |
There was a problem hiding this comment.
To clarify for following reviewers: The actual fix is the addition of GenericClassInstanceMetaclassType and GenericModuleInstanceMetaclassType as accepted types for value_type.
Most of the edits in this files are just refactoring and improvements to error messages.
I would have preferred two separate commits for that (maybe keep that in mind for next time 😄)
asterite
approved these changes
Sep 27, 2021
This was referenced Oct 5, 2021
Closed
straight-shoota
added a commit
to straight-shoota/crystal-website
that referenced
this pull request
Oct 11, 2022
The original example as used in the PR crystal-lang/crystal#11250 but it was stated that this does not work yet with that change.
straight-shoota
added a commit
to straight-shoota/crystal-website
that referenced
this pull request
Oct 11, 2022
The original example as used in the PR crystal-lang/crystal#11250 but it was stated that this does not work yet with that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #10394.
This appears to be simply oversight during the codegen phase.
Note that in the following example:
x's type isFoo.class, which is not virtual, so the assignment will still break. Those remaining specs are marked as pending.