[CI] Remove test_linux_32 and add smoke test for 32-bit gnu #11127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failed dist jobs on circlCI can be ignored. They're just failing because I'm merging a |
beta-ziliani
approved these changes
Aug 26, 2021
straight-shoota
added a commit
to straight-shoota/crystal-book
that referenced
this pull request
Aug 30, 2021
We're experiencing issues with running the automated tests on i386-linux-gnui (see crystal-lang/crystal#11127) and that's unlikely to change anytime soon
straight-shoota
added a commit
to straight-shoota/crystal-book
that referenced
this pull request
Aug 30, 2021
We're experiencing issues with running the automated tests on i386-linux-gnu (see crystal-lang/crystal#11127) and that's unlikely to change anytime soon
straight-shoota
added a commit
to straight-shoota/crystal-book
that referenced
this pull request
Aug 30, 2021
We're experiencing issues with running the automated tests on i386-linux-gnu (see crystal-lang/crystal#11127) and that's unlikely to change anytime soon
straight-shoota
added a commit
to crystal-lang/crystal-book
that referenced
this pull request
Aug 30, 2021
We're experiencing issues with running the automated tests on i386-linux-gnu (see crystal-lang/crystal#11127) and that's unlikely to change anytime soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
32-bit linux specs are broken (#11073) and it appears hard to even diagnose the error or even fix it (#11077). Considering the limited relevance of 32-bit linux platforms, there's not a lot of force behind this.
Having a test that constantly fails doesn't help anything.
The core team decided to move platform support for
i386-linux-gnuto tier 2. The platform is still supported and it's still expected to build (the errors seem to be very specific to the test environment). But we won't run automated tests anymore (at least for the time being). The tests were already incomplete, running onlystd_specon the latest release compiler. But no compiler build orcompiler_spec. So this step is really not a huge change.Closes #11077.