Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken #10109 merge #10821

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Fix broken #10109 merge #10821

merged 1 commit into from
Jun 15, 2021

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Jun 14, 2021

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:regression Something that used to correctly work but no longer works topic:tools:docs-generator labels Jun 14, 2021
@straight-shoota straight-shoota changed the title Fix borken #10109 merge Fix broken #10109 merge Jun 14, 2021
@straight-shoota straight-shoota added this to the 1.1.0 milestone Jun 14, 2021
@Sija
Copy link
Contributor Author

Sija commented Jun 14, 2021

@straight-shoota I don't think it's a regression (unless you mean that it in re: to the master ;))

@straight-shoota
Copy link
Member

Yes, it's a regression in master. Not sure If thats supposed to bei tagged, but I figure it doesnt hurt.

@Sija
Copy link
Contributor Author

Sija commented Jun 14, 2021

IMO that's confusing/conflating terms - regression usually is compared to the previous release, not the master...

@jkthorne
Copy link
Contributor

There are some doc generator specs. Should a spec for this be added since it was a regression?

@Sija
Copy link
Contributor Author

Sija commented Jun 14, 2021

@wontruefree It aint a regression though.

@straight-shoota
Copy link
Member

It broke master. No additional specs necessary.

@bcardiff bcardiff merged commit 3d6fdd5 into crystal-lang:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caspiano caspiano caspiano approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

@jhass jhass jhass approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:regression Something that used to correctly work but no longer works topic:tools:docs-generator
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Sija @straight-shoota @jkthorne @jhass @caspiano @bcardiff