Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatter: Handle leading tuple literals in multi-expression return/break/next properly #10597

Conversation

HertzDevil
Copy link
Contributor

Fixes #10181.

#10193 should work on top of this PR too.

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:tools:formatter labels Apr 5, 2021
Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HertzDevil !

@beta-ziliani beta-ziliani added this to the 1.2.0 milestone Aug 4, 2021
@straight-shoota straight-shoota merged commit 43486b3 into crystal-lang:master Aug 6, 2021
@HertzDevil HertzDevil deleted the bug/formatter-return-multi-exp-tuple branch August 6, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:tools:formatter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to format a method returning tuple
3 participants