Detect cyclic includes between generic modules #10529
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler reports an error when a module cyclically includes itself, but this doesn't work when any generic module is part of the cycle, so this breaks with a stack overflow:
This PR extends the checks to compare generic module instances by their underlying generic modules so that these cases are detected. The generic type arguments don't matter, as ultimately every instantiation of the same module will lead to a recursive include cycle:
Referencing
self
inside generic type arguments is still allowed, e.g.Comparable(self)
, because generic type arguments cannot be used as an included type: