Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't merge NamedTuple metaclasses through instance types #10501

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Don't merge NamedTuple metaclasses through instance types #10501

merged 1 commit into from
Mar 15, 2021

Conversation

HertzDevil
Copy link
Contributor

Follow-up to #6342. Makes the following not crash:

x = typeof({a: 1})
x = typeof({a: 'x'}) # BUG: trying to assign NamedTuple(a: Char | Int32).class <- NamedTuple(a: Int32).class

@bcardiff bcardiff added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:semantic labels Mar 11, 2021
@bcardiff bcardiff added this to the 1.0.0 milestone Mar 12, 2021
@bcardiff bcardiff merged commit 2698c43 into crystal-lang:master Mar 15, 2021
@HertzDevil HertzDevil deleted the bug/namedtuple-metaclass-union branch March 15, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardiff bcardiff bcardiff approved these changes

@asterite asterite asterite approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:semantic
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HertzDevil @asterite @bcardiff