Fix hax extraction of crates depending on some libcrux crates.#1263
Fix hax extraction of crates depending on some libcrux crates.#1263maximebuyse wants to merge 3 commits intomainfrom
Conversation
bda9b4c to
b2d4a36
Compare
b2d4a36 to
9b18681
Compare
|
There is still a problem with the use of |
…xtraction of crates depending on libcrux.
|
This breaks the hax extraction of ml-kem because of this macro. We need the impl produced by the macro to be excluded from the extraction, but adding |
|
@maximebuyse what's the state here? We should try to get this resolved to allow extraction of dependent crates. |
I think I found a way to make it work! I opened a new PR (#1312), I don't want to break things for freedomofpress/securedrop-protocol#131 by messing up this branch. |
When extracting a crate with hax that depends on some libcrux crates, we need these libcrux crates to compile under the
haxcfg. This can be prevented by:cfg(not(hax))(usinghax_lib::excludeis better to remove the problematic items for verification of libcrux using hax).libcrux-intrinsicsinstead of driect use of intrinsics from core_arch needs to be consistent across different libcrux crates.