Test vectors #22
Open
Test vectors #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P2QRHScriptBuf.new_p2qrh(...) function is generating a scriptPubKey value with with back-to-back duplicate OP_PUSHBYTES_32 opcode. #6 jbride/rust-bitcoin#1
performance and failure tests.
|
Looks like the typo checks are failing. Let's also be sure to get the python test vectors. And finally, we'll need to update the BIP Test vectors section to provide an overview similar to this section of BIP-341: |
… that parity bit is always 1
* Rewrote rationale * Fix bolded principles * Actually fix bold * Updates to talk about signature + public key size rather than just signature size * Took a pass over rationale * Started work on specification * Adds example tapscript hybrid signatures * More work on the specification * Cleans up TODO * Fixing grammar, other minor changes * SHL --> SLH * Apply suggestions from code review Co-authored-by: Hunter Beast <hunter@cryptoquick.com> * Adds discussion of SQIsign * Fixes broken llink to libbitcoinpqc Co-authored-by: Hunter Beast <hunter@cryptoquick.com> * Fixes writing in SQIsign section Co-authored-by: Hunter Beast <hunter@cryptoquick.com> * Add rational section on big signatures and public keys * Fixes typos * Adds script validation from BIP 341 * Add commas * Add design section, stack element size increase now in PQ sigs * Fixes typo * Fixes typos and formatting Co-authored-by: Hunter Beast <hunter@cryptoquick.com> * Add authorship to readme * Add diagram of P2QRH merke tree, scriptPubKey and Witness * Remove completed todo * Add security section * Clean up wording, moves some things around * Minor rewording * Review suggestions Co-authored-by: Hunter Beast <hunter@cryptoquick.com> * Clarified size differences * Changed header size and order * does --> doUpdate bip-0360.mediawiki Co-authored-by: Hunter Beast <hunter@cryptoquick.com> * Add related work section * Better scale figure * Respond to review comments * remove double space Co-authored-by: Armin Sabouri <armins88@gmail.com> * Address review comments * Addressing Ademan comments * Sync source svg * Address review * Addresses review * Apply suggestions from code review Co-authored-by: Joey Yandle <xoloki@gmail.com> * Update bip-0360.mediawiki Co-authored-by: Joey Yandle <xoloki@gmail.com> * Update bip-0360.mediawiki Co-authored-by: Joey Yandle <xoloki@gmail.com> * Addressing review comments * Addressing reviews --------- Co-authored-by: Hunter Beast <hunter@cryptoquick.com> Co-authored-by: Armin Sabouri <armins88@gmail.com> Co-authored-by: Joey Yandle <xoloki@gmail.com>
Need to determine if compact size length needs to prefix script and control block (as part of witness stack)
pay-to-quantum-resistant-hash Equivalent example for p2tr is next
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
p2qrh test vectors and documentation