-
Notifications
You must be signed in to change notification settings - Fork 6
Refactor codebase and add missing generics #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
maramihali
commented
Feb 15, 2023
- Created src/testudo_{snark,nizk}.rs that incorporates the Testudo Snark/Nizk functionality, now separated properly between the prover and the verifer.
- Separated the setup, prover and verifier code better in r1csproof.rs
- Added generics to new benchmark and profiler
- Ensures the CI passes
48c44f5 to
02e1fca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good but tbh it is very large changes it is a bit hard to keep track of what is new and what has only been changed of name / place. Anything new except the benchmark changes ?
64731ff to
6d35ef8
Compare
|
So nizk and snark mode (which i'll comment better before merging) are now in separate files rather than everything in |