Skip to content

Conversation

@maramihali
Copy link
Collaborator

  • Created src/testudo_{snark,nizk}.rs that incorporates the Testudo Snark/Nizk functionality, now separated properly between the prover and the verifer.
  • Separated the setup, prover and verifier code better in r1csproof.rs
  • Added generics to new benchmark and profiler
  • Ensures the CI passes

Copy link
Collaborator

@nikkolasg nikkolasg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good but tbh it is very large changes it is a bit hard to keep track of what is new and what has only been changed of name / place. Anything new except the benchmark changes ?

@maramihali
Copy link
Collaborator Author

maramihali commented Feb 15, 2023

So nizk and snark mode (which i'll comment better before merging) are now in separate files rather than everything in lib.rs. The bench and profile are testudo snark specific
And in r1csproof.rs I separated the setup, proving and verification a bit better
And I removed warnings and made CI work

@maramihali maramihali merged commit be30c34 into snarkpack-integration Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants