Feature: recoverable uploads #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leProviderItemIdentifier` This is necessary because the `extensionContext.domainIdentifier` in the FileProviderExtensionUI is not guaranteed to be the `domainIdentifier` of the currently visible `NSFileProviderDomain` and thus a correct XPC connection could not be established.
…fixed error reporting for failed uploads
tobihagemann
requested changes
May 9, 2022
tobihagemann
requested changes
May 9, 2022
Good catch! Regression fixed by 1126699. |
tobihagemann
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the user to restart uploads that have the status "waiting..." or "failed" via customized FileProvider actions in the Files app by long pressing on the file to open the context menu and selecting "Retry Upload".
The upload will be retried directly in case of failed uploads in this case. For files with the status "waiting..." an alert is presented to the user, which shows him, the current upload progress. If there is no upload progress, the user will also be informed. In both cases the user has the possibility to decide if the upload is stuck and if an upload should be tried again.
To enable the customized FileProvider actions, the
NSFileProviderItemIdentifierhad to be changed so that the correspondingNSFileProviderDomainIdentifiercan be derived from them. Because thedomainIdentifierprovided in the FileProviderExtensionUI over theextensionContextis not guaranteed the correctNSFileProviderDomainIdentifierfrom which the action was started. However, it is important for the XPC call to have the correctNSFileProviderDomainIdentifier(otherwise, in the worst case, the upload would be retried for a different file in a different vault).In addition, failed uploads are now correctly displayed again with an upload error in the Files app - the CloudProviderErrors are mapped to an appropriate NSFileProviderError.