Merge pull request #243 from cryptomator/feature/item-metadata-manager-db-improvements

`ItemMetadataDBManager` improvements

Author: phil1995

CryptomatorFileProvider/DB/ItemMetadataDBManager.swift

@@ -80,19 +80,38 @@ class ItemMetadataDBManager: ItemMetadataManager {
 		}
 	}
 
-	// TODO: Optimize Code and/or DB Scheme
 	func cacheMetadata(_ itemMetadataList: [ItemMetadata]) throws {
 		try database.write { db in
 			for metadata in itemMetadataList {
-				if let cachedMetadata = try ItemMetadata.fetchOne(db, key: ["cloudPath": metadata.cloudPath]) {
-					metadata.id = cachedMetadata.id
-					metadata.statusCode = cachedMetadata.statusCode
-					metadata.tagData = cachedMetadata.tagData
-					metadata.favoriteRank = cachedMetadata.favoriteRank
-					try metadata.update(db)
-				} else {
-					try metadata.insert(db)
-				}
+				try db.execute(
+					sql: """
+					INSERT INTO \(ItemMetadata.databaseTableName)
+					(\(ItemMetadata.Columns.name), \(ItemMetadata.Columns.type), \(ItemMetadata.Columns.size), \(ItemMetadata.Columns.parentID), \(ItemMetadata.Columns.lastModifiedDate), \(ItemMetadata.Columns.statusCode), \(ItemMetadata.Columns.cloudPath), \(ItemMetadata.Columns.isPlaceholderItem), \(ItemMetadata.Columns.isMaybeOutdated), \(ItemMetadata.Columns.favoriteRank), \(ItemMetadata.Columns.tagData)) VALUES
+					(:name, :type, :size, :parentID, :lastModifiedDate, :statusCode, :cloudPath, :isPlaceholderItem, :isMaybeOutdated, :favoriteRank, :tagData)
+					ON CONFLICT (\(ItemMetadata.Columns.cloudPath))
+					DO UPDATE SET \(ItemMetadata.Columns.name) = excluded.\(ItemMetadata.Columns.name),
+					\(ItemMetadata.Columns.type) = excluded.\(ItemMetadata.Columns.type),
+					\(ItemMetadata.Columns.size) = excluded.\(ItemMetadata.Columns.size),
+					\(ItemMetadata.Columns.parentID) = excluded.\(ItemMetadata.Columns.parentID),
+					\(ItemMetadata.Columns.lastModifiedDate) = excluded.\(ItemMetadata.Columns.lastModifiedDate),
+					\(ItemMetadata.Columns.cloudPath) = excluded.\(ItemMetadata.Columns.cloudPath),
+					\(ItemMetadata.Columns.isPlaceholderItem) = excluded.\(ItemMetadata.Columns.isPlaceholderItem),
+					\(ItemMetadata.Columns.isMaybeOutdated) = excluded.\(ItemMetadata.Columns.isMaybeOutdated)
+					""",
+					arguments: ["name": metadata.name,
+					            "type": metadata.type,
+					            "size": metadata.size,
+					            "parentID": metadata.parentID,
+					            "lastModifiedDate": metadata.lastModifiedDate,
+					            "statusCode": metadata.statusCode,
+					            "cloudPath": metadata.cloudPath,
+					            "isPlaceholderItem": metadata.isPlaceholderItem,
+					            "isMaybeOutdated": metadata.isMaybeOutdated,
+					            "favoriteRank": metadata.favoriteRank,
+					            "tagData": metadata.tagData]
+				)
+				let metadataID = db.lastInsertedRowID
+				metadata.id = metadataID
 			}
 		}
 	}
@@ -134,11 +153,7 @@ class ItemMetadataDBManager: ItemMetadataManager {
 		_ = try database.write { db in
 			try ItemMetadata
 				.filter(ItemMetadata.Columns.parentID == parentId && !ItemMetadata.Columns.isPlaceholderItem)
-				.fetchAll(db)
-				.forEach {
-					$0.isMaybeOutdated = true
-					try $0.save(db)
-				}
+				.updateAll(db, ItemMetadata.Columns.isMaybeOutdated.set(to: true))
 		}
 	}