Quarkus 3.27.2 #400
Quarkus 3.27.2 #400
Conversation
WalkthroughUpdated backend Quarkus BOM from 3.20.5 to 3.27.2 and edited CHANGELOG.md. Adjusted application.properties keys and test/dev profiles (renamed Swagger UI key, removed a dev Keycloak start-command, added test Keycloak/OIDC flags). Converted multiple JPA embedded ID inner classes to Java records (AccessToken, VaultAccess, EffectiveVaultAccess, EffectiveGroupMembership, EffectiveWot, WotEntry, LegacyAccessToken, RecoveredEmergencyKeyShares) and updated call sites to use record accessors and new constructors; small resource-level construction/access updates (DeviceResource, EmergencyAccessResource, UsersResource, VaultResource). Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 1 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@backend/src/main/java/org/cryptomator/hub/entities/LegacyAccessToken.java`:
- Around line 83-87: The AccessId embeddable record should implement
Serializable to improve interoperability with JPA 3.1 environments and features
like clustering or second-level cache; update the record declaration for
AccessId (record AccessId(...)) to add "implements Serializable", keep the
existing `@Embeddable` and `@Column` annotations intact, and import or add
java.io.Serializable as needed.
🧹 Nitpick comments (1)
backend/src/main/java/org/cryptomator/hub/entities/AccessToken.java (1)
110-112: No@Columnannotations onAccessIdrecord components — verify this is intentional.Unlike every other
@Embeddablerecord in this PR (e.g.,VaultAccess.Id,WotEntry.Id,LegacyAccessToken.AccessId),AccessToken.AccessIddoes not have@Columnannotations on its components. This works because@MapsId("userId")/@MapsId("vaultId")on theuserandvaultrelationships (lines 40–47) drive the column mapping. Just flagging the inconsistency for awareness — if it was intentional (i.e., the old class also lacked@Column), this is fine.#!/bin/bash # Verify whether the old AccessId class had `@Column` annotations before this change git log --all --oneline -n 20 -- 'backend/src/main/java/org/cryptomator/hub/entities/AccessToken.java'
backend/src/main/java/org/cryptomator/hub/entities/LegacyAccessToken.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
This PR updates Quarkus from version 3.20.5 to 3.27.2 LTS and performs necessary code changes to maintain compatibility with the newer version.
Changes:
- Updated Quarkus platform version from 3.20.5 to 3.27.2 in pom.xml and CHANGELOG
- Refactored JPA composite ID classes from mutable Serializable classes to immutable records
- Updated configuration properties to use renamed property names (
enable→enabled)
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| backend/pom.xml | Updated quarkus.platform.version from 3.20.5 to 3.27.2 |
| CHANGELOG.md | Updated version reference in changelog |
| backend/src/main/resources/application.properties | Updated property names (enable → enabled), removed deprecated start-command property, added test configuration to disable dev services |
| backend/src/main/java/org/cryptomator/hub/entities/WotEntry.java | Converted embedded ID class from mutable class to immutable record |
| backend/src/main/java/org/cryptomator/hub/entities/VaultAccess.java | Converted embedded ID class to record, removed default initialization |
| backend/src/main/java/org/cryptomator/hub/entities/RecoveredEmergencyKeyShares.java | Converted embedded ID class to record, removed default initialization |
| backend/src/main/java/org/cryptomator/hub/entities/LegacyAccessToken.java | Converted embedded ID class to record, removed default initialization |
| backend/src/main/java/org/cryptomator/hub/entities/EffectiveWot.java | Converted embedded ID class to record |
| backend/src/main/java/org/cryptomator/hub/entities/EffectiveVaultAccess.java | Converted embedded ID class to record, updated method calls from getter to record accessor |
| backend/src/main/java/org/cryptomator/hub/entities/EffectiveGroupMembership.java | Converted embedded ID class to record, updated instantiation pattern |
| backend/src/main/java/org/cryptomator/hub/entities/AccessToken.java | Converted embedded ID class to record, removed default initialization |
| backend/src/main/java/org/cryptomator/hub/api/VaultResource.java | Updated ID accessor calls from getter methods to record accessors |
| backend/src/main/java/org/cryptomator/hub/api/UsersResource.java | Updated ID instantiation and accessor calls to use record pattern |
| backend/src/main/java/org/cryptomator/hub/api/EmergencyAccessResource.java | Updated ID instantiation to use record constructor |
| backend/src/main/java/org/cryptomator/hub/api/DeviceResource.java | Updated ID accessor calls to use record accessors |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 participants
No description provided.