Add updatable config source #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overheadhunter
requested changes
Oct 25, 2021
spi/src/main/java/org/cryptomator/hub/config/HubConfigPersistence.java
Outdated
Show resolved
Hide resolved
spi/src/main/java/org/cryptomator/hub/config/HubConfigSource.java
Outdated
Show resolved
Hide resolved
spi/src/main/java/org/cryptomator/hub/config/HubConfigSource.java
Outdated
Show resolved
Hide resolved
spi/src/main/java/org/cryptomator/hub/config/HubConfigSourceFactory.java
Outdated
Show resolved
Hide resolved
spi/src/main/java/org/cryptomator/hub/config/HubConfigSourceFactory.java
Outdated
Show resolved
Hide resolved
overheadhunter
requested changes
Oct 26, 2021
spi/src/main/java/org/cryptomator/hub/config/HubConfigSourceFactory.java
Outdated
Show resolved
Hide resolved
* differ betwenn files not exist and other io errors on reading hub config
* configSource only depends on a system property * remove smallRye configSourceFactory * register configSource directly * getProperties returns unmodifiable map * restrict set properties with enum
* use directly the Properties class * synchronized setProperty
…ication.properties
overheadhunter
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an editable, in memory MicroProfile ConfigSource.
The source is provided via the SmallRye ConfigSourceProviderFactory, in order to be able to change the hub config persistence path.Edit: This approach was dropped, instead the config persistence path is taken from the system property
hub.config.path.The whole config is persisted to the path stored in the property
hub.config.path. There is no default, application won't start if the property is not set. After each update of the hub config, it is rewritten to storage. If a properties file is present, it is loaded at config creation.The config can be updated by injection the
HubConfigand callingsetProperty(...).