-
-
Notifications
You must be signed in to change notification settings - Fork 0
Pin GitHub Actions to commit SHAs #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughThe PR updates three GitHub Actions workflows (.github/workflows/build.yml, dependency-check.yml, native-image.yml). Multiple action uses are pinned from generic version tags to exact commit SHAs. dependency-check.yml also changes the scheduled cron from "0 23 * * 0" to "0 12 * * 0", bumps java-version from 21 to 25, removes one slack webhook secret reference and adds ossindex-username and ossindex-token secrets while replacing the slack webhook secret with a different secret name. No control-flow or step-sequence changes were introduced. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/native-image.yml:
- Line 14: The checkout action string in the workflow uses an incorrect
double-at symbol ("actions/checkout@@34e114...") which will break resolution;
update the uses reference in the native-image.yml workflow to the correct
single-at form ("actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5") so
the action can be resolved and executed properly.
🧹 Nitpick comments (1)
.github/workflows/dependency-check.yml (1)
4-4: Additional functional changes beyond SHA pinning.This file includes several changes not mentioned in the PR description:
- Schedule changed from 11 PM to 12 PM Sunday (Line 4)
- New
ossindex-usernameandossindex-tokensecrets (Lines 20-21)- Slack webhook secret changed to
SLACK_WEBHOOK_CRYPTOMATOR_DESKTOP(Line 22)These may be intentional to align with the v3.0.3 reusable workflow, but the PR description only mentions pinning SHAs. Consider updating the PR description or splitting these into a separate commit for clarity.
Also applies to: 20-22
Pin all GitHub Actions and reusable workflows to immutable commit SHAs instead of version tags.
This improves supply-chain security.