Feature: JDK 21 #237
Feature: JDK 21 #237
Conversation
# Conflicts: # pom.xml
WalkthroughThe recent updates involve a comprehensive upgrade of the Java version from 17 to 21 across various GitHub Actions workflow files and project configurations. This transition enhances the development environment, enabling the use of new features and performance improvements. Additionally, the Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant CI/CD
participant Java_21
participant Test_Environment
Developer->>CI/CD: Push changes
CI/CD->>Java_21: Setup Java 21
Java_21->>CI/CD: Java environment ready
CI/CD->>Test_Environment: Run tests with updated mocks
Test_Environment-->>CI/CD: Tests completed
CI/CD->>Developer: Build successful with Java 21
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (9)
- .github/workflows/build.yml (1 hunks)
- .github/workflows/codeql-analysis.yml (1 hunks)
- .github/workflows/dependency-check.yml (1 hunks)
- .github/workflows/publish-central.yml (1 hunks)
- .github/workflows/publish-github.yml (1 hunks)
- .idea/misc.xml (1 hunks)
- pom.xml (3 hunks)
- src/test/java/org/cryptomator/cryptofs/CryptoFileSystemImplTest.java (16 hunks)
- src/test/java/org/cryptomator/cryptofs/CryptoPathMapperTest.java (3 hunks)
Additional comments not posted (21)
.github/workflows/dependency-check.yml (1)
17-17: Java version updated to 21.The Java version has been successfully updated from 17 to 21. This change aligns with the project's goal to leverage JDK 21 features. Ensure that all dependencies are compatible with this version.
.idea/misc.xml (1)
11-11: Project JDK updated to 21.The language level and project JDK have been updated to JDK 21. This change is consistent with the project's upgrade strategy. Ensure that all project configurations and dependencies are compatible with JDK 21.
.github/workflows/codeql-analysis.yml (1)
25-25: Java version updated to 21 for CodeQL analysis.The Java version has been updated from 17 to 21 in the CodeQL analysis workflow. This change supports the project's transition to JDK 21. Ensure that CodeQL and any related tools are compatible with this Java version.
.github/workflows/publish-github.yml (1)
15-15: Verify compatibility with Java 21.The Java version has been updated to 21. Ensure that all dependencies and the build process are compatible with this version.
.github/workflows/publish-central.yml (1)
19-19: Verify compatibility with Java 21.The Java version has been updated to 21. Ensure that all dependencies and the build process are compatible with this version.
.github/workflows/build.yml (1)
17-17: Verify compatibility with Java 21.The Java version has been updated to 21. Ensure that all dependencies and the build process are compatible with this version.
pom.xml (3)
117-117: Switch to Mockito-CoreThe artifact ID has changed from
mockito-inlinetomockito-core. This change might affect how mocks are handled, especially if inline mocking was used. Ensure that all tests function correctly with this change.
30-30: Upgrade Mockito VersionThe Mockito version has been updated from 5.2.0 to 5.12.0. Verify that the tests are compatible with the new version and leverage any new features or improvements.
18-18: Upgrade Java Compiler VersionThe Java compiler version has been upgraded from 17 to 21. Ensure that all dependencies and code are compatible with JDK 21 features and changes.
src/test/java/org/cryptomator/cryptofs/CryptoPathMapperTest.java (3)
293-293: Enhance Directory Existence CheckThe
existsmethod is now mocked to returntruefordirFilePath. This change ensures that the test accurately simulates the existence of the directory, improving test robustness.
309-309: Enhance Symlink Existence CheckThe
existsmethod is now mocked to returntrueforsymlinkFilePath. This change ensures that the test accurately simulates the existence of the symlink, improving test robustness.
327-327: Enhance Shortened File Existence CheckThe
existsmethod is now mocked to returntrueforcontentsFilePath. This change ensures that the test accurately simulates the existence of the shortened file, improving test robustness.src/test/java/org/cryptomator/cryptofs/CryptoFileSystemImplTest.java (9)
961-961: Enhance Parent Directory Existence CheckThe
existsmethod is now mocked to returntrueforciphertextTargetParent. This change ensures that the test accurately simulates the existence of the parent directory, which is crucial for the copy operation.
1010-1010: Enhance Parent Directory Existence Check for Attribute CopyThe
existsmethod is now mocked to returntrueforciphertextTargetParent. This change ensures that the test accurately simulates the existence of the parent directory, which is crucial for copying attributes.
1031-1031: Enhance Parent Directory Existence Check for Owner AttributesThe
existsmethod is now mocked to returntrueforciphertextTargetParent. This change ensures that the test accurately simulates the existence of the parent directory, which is crucial for copying owner attributes.
1055-1055: Enhance Parent Directory Existence Check for POSIX AttributesThe
existsmethod is now mocked to returntrueforciphertextTargetParent. This change ensures that the test accurately simulates the existence of the parent directory, which is crucial for copying POSIX attributes.
1079-1079: Enhance Parent Directory Existence Check for DOS AttributesThe
existsmethod is now mocked to returntrueforciphertextTargetParent. This change ensures that the test accurately simulates the existence of the parent directory, which is crucial for copying DOS attributes.
1175-1175: Enhance Parent Directory Existence Check for Directory CreationThe
existsmethod is now mocked to returntrueforciphertextParent. This change ensures that the test accurately simulates the existence of the parent directory, which is crucial for directory creation.
1205-1205: Enhance Parent Directory Existence Check for Successful Directory CreationThe
existsmethod is now mocked to returntrueforciphertextParent. This change ensures that the test accurately simulates the existence of the parent directory, which is crucial for successful directory creation.
1235-1235: Enhance Parent Directory Existence Check for Directory Creation FailureThe
existsmethod is now mocked to returntrueforciphertextParent. This change ensures that the test accurately simulates the existence of the parent directory, which is crucial for handling directory creation failures.
1276-1276: Enhance Parent Directory Existence Check for Directory ID BackupThe
existsmethod is now mocked to returntrueforciphertextParent. This change ensures that the test accurately simulates the existence of the parent directory, which is crucial for backing up the directory ID.
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
README.md (1)
102-102: Consider changing unordered list style.Markdownlint suggests using a dash instead of an asterisk for unordered lists. While this is a stylistic choice, it may improve consistency.
- * Java 21 + - Java 21Tools
Markdownlint
102-102: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- README.md (2 hunks)
Additional context used
Markdownlint
README.md
102-102: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
Additional comments not posted (2)
README.md (2)
9-9: Good addition of documentation link.The link to the encryption scheme documentation is a valuable addition, enhancing the informational content of the README.
102-102: Update to Java 21 is appropriate.The update to Java 21 reflects the project's transition to a newer JDK version, which aligns with the PR objectives.
Ensure all project dependencies are compatible with Java 21.
Verification successful
Update to Java 21 is appropriate and consistent.
The update to Java 21 in the README.md file is consistent with the codebase. There are no explicit mentions of Java 17 that would indicate compatibility issues.
- README.md: Java version updated to 21.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility of all project dependencies with Java 21. # Test: Check for any dependencies that are incompatible with Java 21. mvn dependency:tree | grep -i "java 17"Length of output: 112
Script:
#!/bin/bash # Search for any explicit mentions of Java 17 or Java 21 in the codebase to check for compatibility issues. rg "Java 17|Java 21" --context 3Length of output: 158
Tools
Markdownlint
102-102: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
This PR updates the project to JDK 21.
Notable adjustments: