Store DirId for every cleartext dir encrypted inside the (cipher) directory #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
overheadhunter
requested changes
Feb 7, 2022
src/main/java/org/cryptomator/cryptofs/dir/DirectoryStreamFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cryptomator/cryptofs/dir/DirectoryStreamFactory.java
Outdated
Show resolved
Hide resolved
src/test/java/org/cryptomator/cryptofs/dir/DirectoryStreamFactoryTest.java
Outdated
Show resolved
Hide resolved
Co-authored by: Sebastian Stenzel <sebastian.stenzel@gmail.com>
overheadhunter
approved these changes
Mar 10, 2022
overheadhunter
requested changes
Mar 15, 2022
src/test/java/org/cryptomator/cryptofs/DeleteNonEmptyCiphertextDirectoryIntegrationTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Sebastian Stenzel <overheadhunter@users.noreply.github.com>
overheadhunter
requested changes
Mar 16, 2022
src/test/java/org/cryptomator/cryptofs/DeleteNonEmptyCiphertextDirectoryIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/cryptomator/cryptofs/DeleteNonEmptyCiphertextDirectoryIntegrationTest.java
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
overheadhunter
approved these changes
Mar 17, 2022
2 tasks
This was referenced Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #113.
In this PR the implementation of #113 is tracked.
On directory creation, a file called
dirid.c9ris placed inside the ciphertext directory.It contains the encrypted directory id in case the ciphertext dir gets orphaned.
The dirid is encrypted via the
EncryptingWriteableByteChannelAPI of cryptolibExisting directories are not migrated, only new directory contain this file.