fix: relax preinstall rules #809
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-nguy
requested review from
JayT106 and
randy-cro
and removed request for
a team
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #809 +/- ##
===========================================
- Coverage 39.68% 39.68% -0.01%
===========================================
Files 189 189
Lines 15580 15582 +2
===========================================
Hits 6183 6183
- Misses 8761 8763 +2
Partials 636 636
🚀 New features to boost your workflow:
|
XinyuCRO
reviewed
Dec 17, 2025
| return errorsmod.Wrapf(types.ErrInvalidPreinstall, | ||
| "preinstall %s, address %s already has an account in account keeper", preinstall.Name, preinstall.Address) | ||
| if ethAcct, ok := acct.(ethermint.EthAccountI); ok { | ||
| if types.IsEmptyCodeHash(ethAcct.GetCodeHash().Bytes()) { |
There was a problem hiding this comment.
Suggested change
| if types.IsEmptyCodeHash(ethAcct.GetCodeHash().Bytes()) { | |
| if !types.IsEmptyCodeHash(ethAcct.GetCodeHash().Bytes()) { |
|
|
||
| } | ||
| // create account with the account keeper and set code hash | ||
| acct = k.accountKeeper.NewAccountWithAddress(ctx, accAddress) |
There was a problem hiding this comment.
with the logic, should only create new account when acct is nil, or use the acct fetched from keeper instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)