Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: changeset verify command return wrong app-hash on old blocks #985

Merged
merged 12 commits into from
Apr 20, 2023
Merged

Problem: changeset verify command return wrong app-hash on old blocks #985

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ca969f2
Problem: changeset verify command return wrong app-hash on old blocks
yihuang Apr 20, 2023
2a33645
Merge remote-tracking branch 'origin/main' into fix-verify
yihuang Apr 20, 2023
bbc2e4e
Update CHANGELOG.md
yihuang Apr 20, 2023
0d744b9
ignore non-exist stores
yihuang Apr 20, 2023
5e9da2b
Merge remote-tracking branch 'fork/fix-verify' into fix-verify
yihuang Apr 20, 2023
b2711ac
Merge branch 'main' into fix-verify
mmsqe Apr 20, 2023
50294a4
make use of scanChangeSetFiles
mmsqe Apr 20, 2023
7922dbb
Merge branch 'main' into fix-verify
yihuang Apr 20, 2023
b3be21e
fix target version
mmsqe Apr 20, 2023
4baa48f
fix lint
mmsqe Apr 20, 2023
5fb0f23
Apply suggestions from code review
yihuang Apr 20, 2023
e57eff1
Update versiondb/client/verify.go
yihuang Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ignore non-exist stores
  • Loading branch information
@yihuang
yihuang committed Apr 20, 2023
commit 0d744b98cdcbfead2de56df1c50150cc06a16882
6 changes: 6 additions & 0 deletions versiondb/client/convert_to_sst.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ func convertSingleStore(store string, changeSetDir, sstDir string, sstFileSize u
if err != nil {
return err
}
if len(csFiles) == 0 {
return nil
}

prefix := []byte(fmt.Sprintf(tsrocksdb.StorePrefixTpl, store))
isEmpty := true
Expand Down Expand Up @@ -179,6 +182,9 @@ func scanChangeSetFiles(changeSetDir, store string) ([]FileWithVersion, error) {
storeDir := filepath.Join(changeSetDir, store)
entries, err := os.ReadDir(storeDir)
if err != nil {
if os.IsNotExist(err) {
return nil, nil
}
return nil, err
}
fileNames := make([]string, len(entries))
Expand Down