-
Notifications
You must be signed in to change notification settings - Fork 273
Problem: export API not supported in memiavl #924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
commented
Mar 14, 2023
Signed-off-by: yihuang <huang@crypto.com>
} | ||
return &iavl.ExportNode{ | ||
Height: int8(height), | ||
Version: int64(node.Version()), |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
Potential integer overflow by integer type conversion
value = node.Value() | ||
} | ||
return &iavl.ExportNode{ | ||
Height: int8(height), |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
Potential integer overflow by integer type conversion
} | ||
|
||
func (e *Exporter) Next() (*iavl.ExportNode, error) { | ||
if int(e.i) >= e.count { |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
Potential integer overflow by integer type conversion
mmsqe
reviewed
Mar 14, 2023
mmsqe
approved these changes
Mar 14, 2023
25 tasks
13 tasks
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)