Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SendToIbc event in smart contract #65

Merged
merged 11 commits into from
Sep 13, 2021
Merged

Support SendToIbc event in smart contract #65

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d28a648
add unit test
thomas-nguy Sep 8, 2021
67eb2e2
fix IbcTransferCoins logic for hook case
thomas-nguy Sep 9, 2021
98ecb24
support transferToIbc log event in smart contract
thomas-nguy Sep 9, 2021
aa44971
add solidity contracts
thomas-nguy Sep 9, 2021
a07d7a4
fix comments and logic check
thomas-nguy Sep 9, 2021
c156067
update changelog
thomas-nguy Sep 9, 2021
0ad0841
update CroBridge.sol
thomas-nguy Sep 10, 2021
de9b933
rename evm events
thomas-nguy Sep 13, 2021
62858c7
fix tests
thomas-nguy Sep 13, 2021
54b91af
add different error message for invalid denom and non associated coin…
thomas-nguy Sep 13, 2021
fc9e5a2
update CroBridge.sol solidity version
thomas-nguy Sep 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update CroBridge.sol
  • Loading branch information
@thomas-nguy
thomas-nguy committed Sep 13, 2021
commit 0ad0841929de5be3821107a9c413dce113f7b6eb
4 changes: 1 addition & 3 deletions contracts/src/CroBridge.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
pragma solidity ^0.6.11;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this if it's not used?
if it's for integration testing, we could also move it to integration_tests/contracts/.


import "ds-token/token.sol";

contract CroBridge {

event __CronosSendToIbc(string recipient, uint256 amount);

// Pay the contract a certain CRO amount and trigger a CRO transfer
// from the contract to recipient through IBC
function send_cro_to_crypto_org(string recipient) public payable {
function send_cro_to_crypto_org(string memory recipient) public payable {
emit __CronosSendToIbc(recipient, msg.value);
}
}