Skip to content

Problem: the sims test triggered by pull request comments does not report final results #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 17, 2022
Merged

Problem: the sims test triggered by pull request comments does not report final results #644

merged 3 commits into from
Aug 17, 2022

Conversation

adu-crypto
Copy link
Contributor

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

close: #643

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@adu-crypto adu-crypto requested a review from a team as a code owner August 15, 2022 10:24
@adu-crypto adu-crypto requested review from yihuang, calvinaco and allthatjazzleo and removed request for a team August 15, 2022 10:24
@adu-crypto
Copy link
Contributor Author

/runsim

@yihuang
Copy link
Contributor

yihuang commented Aug 15, 2022 •
edited
Loading

It may have no effect in current PR. may need to test in forked repo. but let's see see.

@yihuang yihuang closed this Aug 15, 2022
@yihuang yihuang reopened this Aug 15, 2022
@github-actions
Copy link

Simulation tests started and triggered by /runsim.
Can check further progress here

@adu-crypto
Copy link
Contributor Author

did you test in your focked repo?

not yet.
I would test in my forked repo and return to this pr with evidence

@adu-crypto
Copy link
Contributor Author

I've tested on my forked cronos repo: adu-crypto#5
the tests cover the failure and the successful case.
it seems alright.
@allthatjazzleo could you help check and confirm the relevant workflow?

yihuang
yihuang approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adu-crypto
adu-crypto commented Aug 17, 2022
View reviewed changes
@adu-crypto
Copy link
Contributor Author

follow @allthatjazzleo 's advice to add member job and report status only on cronos-dev team membership validation success.
tests passed: adu-crypto#4 (comment)

@yihuang yihuang enabled auto-merge (squash) August 17, 2022 07:52
@yihuang yihuang disabled auto-merge August 17, 2022 08:34
@yihuang yihuang self-requested a review August 17, 2022 08:35
@adu-crypto adu-crypto enabled auto-merge (squash) August 17, 2022 09:02
@adu-crypto adu-crypto merged commit 50e78fe into crypto-org-chain:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvinaco calvinaco Awaiting requested review from calvinaco calvinaco is a code owner automatically assigned from crypto-org-chain/cronos-dev

2 more reviewers

@yihuang yihuang yihuang approved these changes

@allthatjazzleo allthatjazzleo allthatjazzleo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem: the sims test triggered by pull request comments does not report final results
3 participants
@adu-crypto @yihuang @allthatjazzleo