Skip to content

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Aug 12, 2022

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang changed the title support hermes 1.x Problem: latest hermes is not used in integration tests Aug 12, 2022
@mmsqe mmsqe marked this pull request as ready for review August 17, 2022 04:14
@mmsqe mmsqe requested a review from a team as a code owner August 17, 2022 04:14
@mmsqe mmsqe requested review from yihuang and thomas-nguy and removed request for a team August 17, 2022 04:14
Copy link
Contributor

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yihuang
Copy link
Contributor

yihuang commented Aug 17, 2022

@mmsqe
Copy link
Contributor Author

mmsqe commented Aug 17, 2022

integration tests failed: https://github.com/crypto-org-chain/cronos/actions/runs/2872703364

might need merge #639 1st

@yihuang
Copy link
Contributor

yihuang commented Aug 17, 2022

integration tests failed: https://github.com/crypto-org-chain/cronos/actions/runs/2872703364

might need merge #639 1st

I think I've fixed it, let's see

@mmsqe
Copy link
Contributor Author

mmsqe commented Aug 17, 2022

I think I've fixed it, let's see

gas_adjustment get replace with gas_multiplier

@yihuang yihuang merged commit 6bcc4aa into crypto-org-chain:main Aug 17, 2022
@mmsqe mmsqe deleted the update-hermes branch October 18, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants