Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: latest v1.11.x change is not included #1253

Merged
merged 6 commits into from
Dec 7, 2023

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Dec 7, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • Dependency Upgrades

    • Upgraded Go-Ethereum to version v1.11.6 for enhanced interaction with Ethereum components.
  • Build Configuration

    • Updated Go module build configuration to use buildGo120Module for improved build processes.
  • New Features and Improvements

    • Modified CallEVM function to return a *core.Message for better alignment with internal Ethereum message structures.
    • Adjusted DeployModuleCRC21 function to directly access the nonce property, streamlining address creation.
  • Tests

    • Updated TestEvmHooks to use core.Message{} in place of nil for more accurate Ethereum transaction processing tests.

Copy link
Contributor

coderabbitai bot commented Dec 7, 2023

Walkthrough

The changes involve updates to Go-Ethereum dependencies, a shift from Go 1.18 to Go 1.20 for the build module, and modifications to function signatures and behavior in the codebase. These updates likely enhance compatibility with newer Ethereum features and improve the build process, while the code alterations adjust to the updated dependencies and refine the system's functionality.

Changes

File Path Change Summary
CHANGELOG.md Added dependency upgrade for Go-Ethereum to v1.11.6.
nix/default.nix Updated buildGoModule from Go 1.18 to Go 1.20.
nix/go-ethereum.nix Updated Go-Ethereum version from 1.11.2 to 1.11.6 and changed SHA256 hashes.
x/cronos/keeper/evm.go Changed return type in CallEVM and updated DeployModuleCRC21 function.
x/cronos/keeper/evm_hooks_test.go Replaced nil with core.Message{} in TestEvmHooks function.
integration_tests/test_ibc_rly_gas.py Changed value assigned to the variable diff from 0.004 to 0.005.

Poem

🐇✨
In the realm of code, where the data streams flow,
A rabbit hopped through, with updates in tow.
From Go-Ethereum's rise to version's new height,
To Go modules built with more power and might. 🚀🌟


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: mmsqe <mavis@crypto.com>
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #1253 (a4d9479) into main (f97e655) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1253      +/-   ##
==========================================
+ Coverage   35.75%   35.77%   +0.01%     
==========================================
  Files         116      116              
  Lines       10663    10665       +2     
==========================================
+ Hits         3813     3815       +2     
  Misses       6474     6474              
  Partials      376      376              
Files Coverage Δ
x/cronos/keeper/evm.go 53.62% <100.00%> (+0.68%) ⬆️

@mmsqe mmsqe marked this pull request as ready for review December 7, 2023 06:53
@mmsqe mmsqe requested a review from a team as a code owner December 7, 2023 06:53
@mmsqe mmsqe requested review from yihuang and thomas-nguy and removed request for a team December 7, 2023 06:53
@mmsqe mmsqe enabled auto-merge December 7, 2023 06:55
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between f97e655 and 007624c.
Files ignored due to filter (3)
  • go.mod
  • go.sum
  • gomod2nix.toml
Files selected for processing (5)
  • CHANGELOG.md (1 hunks)
  • nix/default.nix (1 hunks)
  • nix/go-ethereum.nix (1 hunks)
  • x/cronos/keeper/evm.go (3 hunks)
  • x/cronos/keeper/evm_hooks_test.go (7 hunks)
Files skipped from review due to trivial changes (1)
  • nix/go-ethereum.nix
Additional comments: 12
CHANGELOG.md (1)
  • 24-26: The summary states that Go-Ethereum was upgraded to v1.11.6, but the hunk shows an upgrade to v1.11.2. Please ensure the summary reflects the actual changes made in the code.
nix/default.nix (2)
  • 11-11: The update from buildGo118Module to buildGo120Module is noted and aligns with the PR's objective to upgrade the Go language version used in the build process.

  • 8-14: > Note: This review was outside the patches, and no patch overlapping with it was found. Original lines [25-29]

The cosmovisor package is still using buildGo118Module. Confirm if this is intentional or if it should also be upgraded to buildGo120Module for consistency and compatibility with the Go version upgrade.

x/cronos/keeper/evm.go (2)
  • 22-37: The change from *ethtypes.Message to *core.Message in the CallEVM function's return type is correct and aligns with the updated dependencies and internal logic modifications.

  • 86-86: The change from msg.Nonce() to msg.Nonce in the DeployModuleCRC21 function is correct and reflects the updated structure of the Message type.

x/cronos/keeper/evm_hooks_test.go (7)
  • 17-22: The import of core from github.com/ethereum/go-ethereum/core is consistent with the use of core.Message{} in the test cases, which aligns with the summary provided.

  • 44-50: The use of core.Message{} instead of nil as an argument to PostTxProcessing is consistent across all test cases, which confirms the change mentioned in the summary.

  • 66-72: The use of core.Message{} instead of nil as an argument to PostTxProcessing is consistent across all test cases, which confirms the change mentioned in the summary.

  • 96-102: The use of core.Message{} instead of nil as an argument to PostTxProcessing is consistent across all test cases, which confirms the change mentioned in the summary.

  • 139-145: The use of core.Message{} instead of nil as an argument to PostTxProcessing is consistent across all test cases, which confirms the change mentioned in the summary.

  • 179-185: The use of core.Message{} instead of nil as an argument to PostTxProcessing is consistent across all test cases, which confirms the change mentioned in the summary.

  • 234-240: The use of core.Message{} instead of nil as an argument to PostTxProcessing is consistent across all test cases, which confirms the change mentioned in the summary.

@mmsqe mmsqe added this pull request to the merge queue Dec 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 7, 2023
@mmsqe mmsqe added this pull request to the merge queue Dec 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 7, 2023
@mmsqe mmsqe enabled auto-merge December 7, 2023 09:02
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 007624c and a4d9479.
Files selected for processing (1)
  • integration_tests/test_ibc_rly_gas.py (1 hunks)
Additional comments: 1
integration_tests/test_ibc_rly_gas.py (1)
  • 24-24: The change in the value of diff from 0.004 to 0.005 will affect the assertion tolerance in the test. Ensure this new tolerance level is as intended and consistent with the test requirements.

@mmsqe mmsqe added this pull request to the merge queue Dec 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 7, 2023
@mmsqe mmsqe added this pull request to the merge queue Dec 7, 2023
Merged via the queue into crypto-org-chain:main with commit 95da881 Dec 7, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants