-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: latest v1.11.x change is not included #1253
Conversation
WalkthroughThe changes involve updates to Go-Ethereum dependencies, a shift from Go 1.18 to Go 1.20 for the build module, and modifications to function signatures and behavior in the codebase. These updates likely enhance compatibility with newer Ethereum features and improve the build process, while the code alterations adjust to the updated dependencies and refine the system's functionality. Changes
Poem
TipsChat with CodeRabbit Bot (
|
Signed-off-by: mmsqe <mavis@crypto.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1253 +/- ##
==========================================
+ Coverage 35.75% 35.77% +0.01%
==========================================
Files 116 116
Lines 10663 10665 +2
==========================================
+ Hits 3813 3815 +2
Misses 6474 6474
Partials 376 376
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (3)
- go.mod
- go.sum
- gomod2nix.toml
Files selected for processing (5)
- CHANGELOG.md (1 hunks)
- nix/default.nix (1 hunks)
- nix/go-ethereum.nix (1 hunks)
- x/cronos/keeper/evm.go (3 hunks)
- x/cronos/keeper/evm_hooks_test.go (7 hunks)
Files skipped from review due to trivial changes (1)
- nix/go-ethereum.nix
Additional comments: 12
CHANGELOG.md (1)
- 24-26: The summary states that Go-Ethereum was upgraded to
v1.11.6
, but the hunk shows an upgrade tov1.11.2
. Please ensure the summary reflects the actual changes made in the code.nix/default.nix (2)
11-11: The update from
buildGo118Module
tobuildGo120Module
is noted and aligns with the PR's objective to upgrade the Go language version used in the build process.8-14: > Note: This review was outside the patches, and no patch overlapping with it was found. Original lines [25-29]
The
cosmovisor
package is still usingbuildGo118Module
. Confirm if this is intentional or if it should also be upgraded tobuildGo120Module
for consistency and compatibility with the Go version upgrade.x/cronos/keeper/evm.go (2)
22-37: The change from
*ethtypes.Message
to*core.Message
in theCallEVM
function's return type is correct and aligns with the updated dependencies and internal logic modifications.86-86: The change from
msg.Nonce()
tomsg.Nonce
in theDeployModuleCRC21
function is correct and reflects the updated structure of theMessage
type.x/cronos/keeper/evm_hooks_test.go (7)
17-22: The import of
core
fromgithub.com/ethereum/go-ethereum/core
is consistent with the use ofcore.Message{}
in the test cases, which aligns with the summary provided.44-50: The use of
core.Message{}
instead ofnil
as an argument toPostTxProcessing
is consistent across all test cases, which confirms the change mentioned in the summary.66-72: The use of
core.Message{}
instead ofnil
as an argument toPostTxProcessing
is consistent across all test cases, which confirms the change mentioned in the summary.96-102: The use of
core.Message{}
instead ofnil
as an argument toPostTxProcessing
is consistent across all test cases, which confirms the change mentioned in the summary.139-145: The use of
core.Message{}
instead ofnil
as an argument toPostTxProcessing
is consistent across all test cases, which confirms the change mentioned in the summary.179-185: The use of
core.Message{}
instead ofnil
as an argument toPostTxProcessing
is consistent across all test cases, which confirms the change mentioned in the summary.234-240: The use of
core.Message{}
instead ofnil
as an argument toPostTxProcessing
is consistent across all test cases, which confirms the change mentioned in the summary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- integration_tests/test_ibc_rly_gas.py (1 hunks)
Additional comments: 1
integration_tests/test_ibc_rly_gas.py (1)
- 24-24: The change in the value of
diff
from 0.004 to 0.005 will affect the assertion tolerance in the test. Ensure this new tolerance level is as intended and consistent with the test requirements.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit
Dependency Upgrades
v1.11.6
for enhanced interaction with Ethereum components.Build Configuration
buildGo120Module
for improved build processes.New Features and Improvements
CallEVM
function to return a*core.Message
for better alignment with internal Ethereum message structures.DeployModuleCRC21
function to directly access the nonce property, streamlining address creation.Tests
TestEvmHooks
to usecore.Message{}
in place ofnil
for more accurate Ethereum transaction processing tests.